-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ee core] make cheat engine a togleable feature #27
base: master
Are you sure you want to change the base?
[ee core] make cheat engine a togleable feature #27
Conversation
to save a bit of EE RAM when not needed?
It's a shame we can't use a modular approach like we do on the IOP for the EE also. But adding a compile time I would prefer to keep it a single (full featured) ee_core. If the ee_core becomes too big we can put code into specific sections using the linkfile. Like for instance:
|
My intention was never to make this a variant compiled all the time. The idea is just to make it togleable. if someone wants EE Core without cheat engine, then only recompiling will be needed, no code touching. thats why this PR didnt touch a single byte of the CI file |
If you want/need this for your development then I can merge it. But I personally don't see a need, only 20 added lines of (for me) useless code. |
yeah, buf it you wanna strip it away, you just set a make variable instead of touching code. |
If you fix the merge conflict I'll merge the change. |
to save a bit of EE RAM when not needed?