Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ee core] make cheat engine a togleable feature #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

israpps
Copy link
Contributor

@israpps israpps commented Jun 19, 2024

to save a bit of EE RAM when not needed?

to save a bit of EE RAM when not needed?
@rickgaiser
Copy link
Owner

It's a shame we can't use a modular approach like we do on the IOP for the EE also. But adding a compile time #ifdef like this will result in 2x the number of ee_core.elf files, and that number can grow very fast. For instance 4 feature ifdef's result in 2^4=16 different versions.

I would prefer to keep it a single (full featured) ee_core. If the ee_core becomes too big we can put code into specific sections using the linkfile. Like for instance:

  • essential code -> 0x00084000
  • non-essential (feature) code -> 0x000D0000
    If a game overwrites non used feature code, then everything will still work as expected.

@rickgaiser rickgaiser closed this Jul 8, 2024
@israpps
Copy link
Contributor Author

israpps commented Jul 8, 2024

It's a shame we can't use a modular approach like we do on the IOP for the EE also. But adding a compile time #ifdef like this will result in 2x the number of ee_core.elf files, and that number can grow very fast. For instance 4 feature ifdef's result in 2^4=16 different versions.

I would prefer to keep it a single (full featured) ee_core. If the ee_core becomes too big we can put code into specific sections using the linkfile. Like for instance:

  • essential code -> 0x00084000
  • non-essential (feature) code -> 0x000D0000
    If a game overwrites non used feature code, then everything will still work as expected.

My intention was never to make this a variant compiled all the time.

The idea is just to make it togleable. if someone wants EE Core without cheat engine, then only recompiling will be needed, no code touching. thats why this PR didnt touch a single byte of the CI file

@israpps
Copy link
Contributor Author

israpps commented Jul 12, 2024

@rickgaiser

@rickgaiser
Copy link
Owner

If you want/need this for your development then I can merge it. But I personally don't see a need, only 20 added lines of (for me) useless code.

@rickgaiser rickgaiser reopened this Jul 12, 2024
@israpps
Copy link
Contributor Author

israpps commented Jul 12, 2024

If you want/need this for your development then I can merge it. But I personally don't see a need, only 20 added lines of (for me) useless code.

yeah, buf it you wanna strip it away, you just set a make variable instead of touching code.

@rickgaiser
Copy link
Owner

If you fix the merge conflict I'll merge the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants